Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for ruby 3 #395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add support for ruby 3 #395

wants to merge 1 commit into from

Conversation

g-arjones
Copy link
Contributor

@g-arjones g-arjones commented Mar 2, 2023 •
edited
Loading

@g-arjones g-arjones requested a review from doudou March 2, 2023 18:22
@g-arjones g-arjones force-pushed the migrate_to_ruby3 branch 3 times, most recently from c8f6d0d to 090731f Compare July 4, 2023 00:15
@g-arjones
Copy link
Contributor Author

g-arjones commented Apr 21, 2024 •
edited
Loading

@doudou Do you still have plans to merge this? It's been over a year...

@g-arjones
Copy link
Contributor Author

@doudou Ping?

@doudou
Copy link
Member

doudou commented May 7, 2024

Just came back to it ... The tests don't pass in CI and I can't check it out ... you remember what's up ?

@g-arjones
Copy link
Contributor Author

Did you release flexmock?

@doudou
Copy link
Member

doudou commented May 8, 2024 •
edited
Loading

I ... didn't even notice that your pull request on flexmock was towards my branch and not master ... This whole thing got completely lost.

Adding it on top of my list (instead of bottom ...)

@g-arjones
Copy link
Contributor Author

No problem... I think you will have to release it as a new major because as far as I remember, some of the changes break API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doudou doudou Awaiting requested review from doudou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-arjones @doudou