Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for msys2 installations on win64 #90

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

planthaber
Copy link
Member

"msys2" (https://msys2.github.io/) is a build environment for mingw on windows that includes a package manager (based on cygwin and mingw)

rescue Errno::EEXIST
FileUtils.rm_rf to
FileUtils.ln_sf from, to
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know what to do here, msys2 internally avoids symlinks and is doing a copy instead, so at the second execution, FileUtils.ln_sf throws Errno::EEXIST.

Ignoring the call leads to non-updating autoproj/remotes folders, deleting them works, but local changes could be lost

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you use the windows way?

         Dir.create_junction(to, from)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is available in the win32-dir gem, but sadly, that is not compatible with msys2.

@goldhoorn
Copy link
Contributor

@doudou: do you want a rebase against autobuild2.0 otherwise 👍 for merge

@doudou
Copy link
Member

doudou commented Oct 10, 2015

@doudou: do you want a rebase against autobuild2.0

Against autoproj-2.0, yes. I'm not going to release any new 1.x release (well, probably one, but with zero new functionality, just avoiding auto-update to autoproj 2.0)

@goldhoorn
Copy link
Contributor

@planthaber: can you update this PR?

@planthaber
Copy link
Member Author

It is on the agenda, but Autoproj 2 moved a lot of changed functions to separate files which makes merging more difficult as i have to find the new locations first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants