-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for msys2 installations on win64 #90
base: master
Are you sure you want to change the base?
Conversation
rescue Errno::EEXIST | ||
FileUtils.rm_rf to | ||
FileUtils.ln_sf from, to | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know what to do here, msys2 internally avoids symlinks and is doing a copy instead, so at the second execution, FileUtils.ln_sf throws Errno::EEXIST.
Ignoring the call leads to non-updating autoproj/remotes folders, deleting them works, but local changes could be lost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if you use the windows way?
Dir.create_junction(to, from)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is available in the win32-dir gem, but sadly, that is not compatible with msys2.
@doudou: do you want a rebase against autobuild2.0 otherwise 👍 for merge |
Against autoproj-2.0, yes. I'm not going to release any new 1.x release (well, probably one, but with zero new functionality, just avoiding auto-update to autoproj 2.0) |
@planthaber: can you update this PR? |
It is on the agenda, but Autoproj 2 moved a lot of changed functions to separate files which makes merging more difficult as i have to find the new locations first |
osdeps added for ruby 22 and 23
"msys2" (https://msys2.github.io/) is a build environment for mingw on windows that includes a package manager (based on cygwin and mingw)