Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible incorrect code #485

Open
egdolber opened this issue Aug 23, 2020 · 1 comment
Open

Possible incorrect code #485

egdolber opened this issue Aug 23, 2020 · 1 comment

Comments

@egdolber
Copy link

Chapter 8, Pg 108, file app/routes/bands.js: BandsRoute.model() returns "this.catalog.bands". At this point in the project, I think BandsRoute.model() should return "this.catalog.getBands()"

@balinterdi
Copy link
Collaborator

The songs and bands getters are the very first thing we add to the service and we only change the bands.js route to return this.storage.bands after that. So unless I'm misunderstanding something, this should work.

(I'm talking about the latest release 20200805.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants