Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add basic circleci json validation on pr submissions #188

Closed
phillxnet opened this issue May 13, 2019 · 2 comments
Closed

add basic circleci json validation on pr submissions #188

phillxnet opened this issue May 13, 2019 · 2 comments

Comments

@phillxnet
Copy link
Member

The free plan of circleci should enable a post pr submission json lint check to validate, at least syntactically, each pr and provide in place feedback on this check within the pr itself. This would form the first step in reviewing a pull request and avoid admins having to correct basic errors that are easily made / rectified prior to human review.
@phillxnet
Copy link
Member Author

Also consider GitHub Actions as an alternative for the same function.

@phillxnet
Copy link
Member Author

Closing as a functional duplicate of #91. Sorry folks for the noise here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phillxnet