Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bootstrap js/css #2548

Open
kanecko opened this issue May 2, 2023 · 2 comments
Open

Upgrade bootstrap js/css #2548

kanecko opened this issue May 2, 2023 · 2 comments
Labels
UI-enhancement Enhancement, renovation, update within Web-UI.

Comments

@kanecko
Copy link
Contributor

kanecko commented May 2, 2023

Issue (correctly placed) in rockstor-jslibs: rockstor/rockstor-jslibs#30

Upgrading bootstrap to at least 4.6 would be nice.
The license and supported browsers look fine.

Reasoning: it has built-in switches. This means we could remove the dependency to external bootstrap-switch library.
Cons: there will be breaking changes (https://getbootstrap.com/docs/4.6/migration/, https://getbootstrap.com/docs/5.2/migration/)

My opinion: since v3.x works fine with latest modern browsers, there is no rush to upgrade.
Therefore it is a nice-to-have, but alas a low-prio task.

@phillxnet
Copy link
Member

@kanecko Thanks for creating this issue. Lets try and get this sorted once we have our current Milestone sorted and have then kicked off the next testing channel stint. That way we can handle the inevitable breakage more easily: breakage is more acceptable in earlier testing channel.

Also agreed on good idea to reduce dependencies, we have them all over the place at the moment.
Would you mind making a companion issue to this (linked between them) in our jslibs repo:
https://github.com/rockstor/rockstor-jslibs
And from my recent audit there I think bootstrap-switch is now one of our oldest dependencies, and likely no longer maintained. So it would be grand to drop that as soon as we can.

I'm not sure but this issue seems like it could be a can of worms, but never-the-less it would be great to get us upgraded as resources allow.

@kanecko
Copy link
Contributor Author

kanecko commented May 2, 2023

Hah, I see there are yet more bootstrap plugins.
Indeed it will surely be a can of worms...

@phillxnet phillxnet added the UI-enhancement Enhancement, renovation, update within Web-UI. label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI-enhancement Enhancement, renovation, update within Web-UI.
Projects
None yet
Development

No branches or pull requests

2 participants