Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poetry as an rpmbuild host requirement #64

Open
phillxnet opened this issue Feb 9, 2024 · 0 comments
Open

Add poetry as an rpmbuild host requirement #64

phillxnet opened this issue Feb 9, 2024 · 0 comments

Comments

@phillxnet
Copy link
Member

Since "Move build.sh execution from %posttrans to rockstor-build.service #61" #63 the rpmbuild scriptlets no longer manage the installation of Poetry:

Removal of redundant Poetry install/update. We now assume this of our build host, and assert rockstor-build.service / build.sh as the sole source of truth for this.

resulting in %build% failing with poetry: command not found when attempting to run rpmbuild on non prior rockstor instances: i.e. where rockstor-build.service (build.sh) has already arranged our poetry dependency via our preferred python311-pipx arrangement.

Ideally we need an additional README.md section detailing to the specific build host requirements assumed. We currently have the following paragraph:

Using an existing Rockstor install ensures that at least our prior dependencies are in place. This helps with establishing if any new dependencies are required when making spec file changes. The rpmbuild process, within the %check scriptlet, also runs all our existing unit tests. As such a properly configured and running Postgres server is required. The prior installs rockstor-pre.service (initrock) would have asserted these conditions. Otherwise the rpmbuild command will fail on the %check scriptlet stage.

It is proposed that this be moved to for example a Build Host assumptions with details on how, using the rockstor-core code (relevant branch) where possible, can be sourced to effect the buildhost requirements for rpmbuild. This would also assist in ensuring the minimal changes required to rpmbuild on for example a MinimalVM openSUSE image derived build host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant