You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since "Move build.sh execution from %posttrans to rockstor-build.service #61" #63 the rpmbuild scriptlets no longer manage the installation of Poetry:
Removal of redundant Poetry install/update. We now assume this of our build host, and assert rockstor-build.service / build.sh as the sole source of truth for this.
resulting in %build% failing with poetry: command not found when attempting to run rpmbuild on non prior rockstor instances: i.e. where rockstor-build.service (build.sh) has already arranged our poetry dependency via our preferred python311-pipx arrangement.
Ideally we need an additional README.md section detailing to the specific build host requirements assumed. We currently have the following paragraph:
Using an existing Rockstor install ensures that at least our prior dependencies are in place. This helps with establishing if any new dependencies are required when making spec file changes. The rpmbuild process, within the %check scriptlet, also runs all our existing unit tests. As such a properly configured and running Postgres server is required. The prior installs rockstor-pre.service (initrock) would have asserted these conditions. Otherwise the rpmbuild command will fail on the %check scriptlet stage.
It is proposed that this be moved to for example a Build Host assumptions with details on how, using the rockstor-core code (relevant branch) where possible, can be sourced to effect the buildhost requirements for rpmbuild. This would also assist in ensuring the minimal changes required to rpmbuild on for example a MinimalVM openSUSE image derived build host.
The text was updated successfully, but these errors were encountered:
Since "Move build.sh execution from %posttrans to rockstor-build.service #61" #63 the rpmbuild scriptlets no longer manage the installation of Poetry:
resulting in %build% failing with
poetry: command not found
when attempting to run rpmbuild on non prior rockstor instances: i.e. where rockstor-build.service (build.sh) has already arranged our poetry dependency via our preferred python311-pipx arrangement.Ideally we need an additional README.md section detailing to the specific build host requirements assumed. We currently have the following paragraph:
It is proposed that this be moved to for example a Build Host assumptions with details on how, using the rockstor-core code (relevant branch) where possible, can be sourced to effect the buildhost requirements for rpmbuild. This would also assist in ensuring the minimal changes required to rpmbuild on for example a MinimalVM openSUSE image derived build host.
The text was updated successfully, but these errors were encountered: