Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for async writer and reader #331

Open
cassanof opened this issue Jul 28, 2023 · 4 comments
Open

Support for async writer and reader #331

cassanof opened this issue Jul 28, 2023 · 4 comments

Comments

@cassanof
Copy link
Contributor

Hello, it would be nice to get support for AsyncWrite and AsyncRead, either from Tokio or futures to serialize/deserialize rbxl binary and xml blobs.
I would be happy to do implement it if it's not a problem.

@kennethloeffler
Copy link
Member

Hi Federico,

I think rbx_xml and rbx_binary crate features for async reads/writes would be great to have. If you're able, can you describe your use case? This will help justify the addition, and also satisfy my own curiosity 😄

@cassanof
Copy link
Contributor Author

Hey Kenneth! Sorry, I would like to go into detail but I cannot. Abstractly, it would empower systems that rely on parsing rbx files asynchronously, without blocking.

@Dekkonot
Copy link
Member

We're preparing for a new release soon, so it's unlikely that this will make it in before then but I would love to support this. If you want to implement it, feel free but otherwise either me or Ken will get to it soon enough!

@cassanof
Copy link
Contributor Author

Nice! SGTM. I'll way for the new release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants