Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly Implement mlua::UserData on rbx_types::* #454

Open
krakow10 opened this issue Oct 6, 2024 · 1 comment
Open

Directly Implement mlua::UserData on rbx_types::* #454

krakow10 opened this issue Oct 6, 2024 · 1 comment
Labels

Comments

@krakow10
Copy link
Contributor

krakow10 commented Oct 6, 2024

I'm making a roblox emulator and noticed it would be convenient to directly implement mlua::UserData on types such as CFrame. My expectation is that this would be seen as a maintenance burden rather than a worthwhile feature, so I'm opening an issue.

@kennethloeffler
Copy link
Member

kennethloeffler commented Nov 4, 2024

I'm not against this, since it seems like it's common for consumers to want to expose rbx_types to Lua, mlua is widely used, and it wouldn't require a lot of ongoing maintenance. I'd accept a PR to do so, as long as it's gated behind a feature.

Before anyone starts work on this, they should review Lune's implementation and ensure that rbx-dom mlua feature will work for Lune with minimal changes, since Lune is the most prominent consumer of rbx-types that needs to expose rbx-types to Lua.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants