Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Populate photoUrl and pronunciationUrl for all account profiles #731

Open
mihail-varbanov opened this issue Dec 3, 2024 · 1 comment

Comments

@mihail-varbanov
Copy link

For all user accounts, we need to populate photoUrl and pronunciationUrl from their profiles with valid URLs, depending on whether these accounts have uploaded profile photo or voice recording in Content BB. In the beginning we should do this only for dev, when we release 6.1 we should do the same on production. Please note that this does not affect user's privacy in any way, this just puts things in the right way.

Source: rokwire/illinois-app#4402
More: https://rokwire-workspace.slack.com/archives/C0325LZQE6N/p1732695230462189
CC: @pmarkhennessy, @petyos, @roberlander2.

@roberlander2
Copy link
Contributor

Hi @mihail-varbanov,

@shurwit and I were discussing this issue and we are thinking that it would be best if the client handled these URL updates in account profiles. The general idea is that when a user starts the client, it should check whether the user's profile contains photoUrl and pronunciationUrl, and if these are missing and this user has uploaded the respective profile photo and voice recording to the Content BB, the client should make a request to the Core BB PUT /account/profile API to set these two fields.

We believe that this rolling update to account profiles will not be an issue because we do not plan to make profile photos or pronunciation audios visible in the directory by default. Since users will need to set their profile photo and pronunciation audio to public visibility manually, it will not matter that some accounts will not have these fields populated until those users open the app.

Please let me know your thoughts on this plan. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants