Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default affected People does not work for Symfony 6 (private Services) #91

Open
Chris53897 opened this issue Feb 24, 2023 · 7 comments · May be fixed by #90
Open

Default affected People does not work for Symfony 6 (private Services) #91

Chris53897 opened this issue Feb 24, 2023 · 7 comments · May be fixed by #90
Assignees
@danielmorell

Comments

@Chris53897
Copy link

The default person_fn does not work for me. I use Symfony 6.2, version 4 of this repo.
Over my PR.
But i am not sure if i am doing anything wrong, or at which point is does not work.

https://docs.rollbar.com/docs/person-tracking
https://docs.rollbar.com/docs/symfony#person_fn-configuration-option

The field: body.extra.token.user_identifier is set correcty in the Item-Report in Rollbar.
But Rollbar does not seems to understand, that this is the user.

@danielmorell Maybe you can have a look?
@danielmorell danielmorell self-assigned this Feb 27, 2023
@danielmorell
Copy link
Collaborator

Sorry for the long wait on this one @Chris53897!

Can you help me understand where you are seeing the body.extra.token.user_identifier field. Is that the raw JSON in the Rollbar platform?

I believe the raw JSON should look more like this...

{
    "body": {
        // Stuff...
    },
    "person": {
        "id": "<some id>",
        "username": "<username>",
        "email": "<email>",
    }
}

The default person function is found here https://github.com/rollbar/rollbar-php-symfony-bundle/blob/master/Factories/RollbarHandlerFactory.php for Rollbar Symfony.

@Chris53897
Copy link
Author

@danielmorell Thanks for reply. The field body.extra.token.user_identifier field was my username (as plain string)
I will have a look as soon if i found some free time.

@Chris53897 Chris53897 changed the title Default affected People does not work for me Default affected People does not work for Symfony 6 (private Services) May 9, 2023
@Chris53897 Chris53897 linked a pull request May 9, 2023 that will close this issue
Open
1 task
@Chris53897
Copy link
Author

I opened this Issue on the wrong repo. Could be moved to https://github.com/rollbar/rollbar-php-symfony-bundle/issues

@danielmorell danielmorell transferred this issue from rollbar/rollbar-php May 19, 2023
@ghost
Copy link

ghost commented May 23, 2023

I'll close this issue, as it's in a wrong repo.

@ghost ghost closed this as completed May 23, 2023
@Chris53897
Copy link
Author

Chris53897 commented May 23, 2023 •
edited
Loading

@rollbar-bborsits ? It was already moved 4 days ago to this (correct) Repo. Please reopen

@ghost ghost reopened this May 23, 2023
@ghost
Copy link

ghost commented May 23, 2023

@Chris53897 Apology, I mixed up the repos. You're right, so I reopened it.

@Chris53897
Copy link
Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmorell danielmorell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: default fn-username behaviour Chris53897/rollbar-php-symfony-bundle
2 participants
@Chris53897 @danielmorell