Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle CI build coverage uploads? #267

Open
rollbear opened this issue Dec 7, 2021 · 0 comments
Open

How to handle CI build coverage uploads? #267

rollbear opened this issue Dec 7, 2021 · 0 comments

Comments

@rollbear
Copy link
Owner

rollbear commented Dec 7, 2021

The state of things right now is that (line) coverage is collected with kcov for Linux builds only, and is forwarded to codecov.io.

There are several problems here, however.

  • kcov is (not quite, but effectively) linux only, and it is incompatible with sanitizer builds, which requires a separate step. This project is not married to kcov, so we can use other solutions.
  • codecov.io has a limit on the number of coverage uploads it accepts for a single commit SHA-1. We're currently close enough to that limit that a release-push to main plus a tag for the same commit causes uploads to fail because the number of allowed uploads for one commit has been exceeded.
  • Regardless of why, the failure to upload coverage information is not a cause to fail a build, even though it is worthy of notice. Is there a middle ground between pass/fail? I have no problem with a release tag build failing an upload if it refers to a successful build of the same git commit, but i also want successful coverage information to PR builds so that I can easily judge if the PR should have more tests or not.
  • Can we improve this by collecting coverage information for non-linux builds?

What options do we have to improve the above? Discus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant