feat(rome_js_parser, rome_js_formatter): support `using` and `await using` declaration #4737

nissy-dev · 2023-07-29T13:30:11Z

Summary

Fix a part of #4646

This PR is basic support for using and await using declaration.
After merging this PR, I will check if we need to modify more existing lint rules and create another PR for resolving todo tests.

Test Plan

I added some parser tests based on esbuild test cases
ref: https://github.com/evanw/esbuild/blob/af7cfc5d0d5108aae0f9f02447f08761e9b604f2/internal/js_parser/js_parser_test.go#L6090

netlify · 2023-07-29T13:30:15Z

✅ Deploy Preview for docs-rometools canceled.

Name	Link
🔨 Latest commit	`f4c46bd`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-rometools/deploys/64cfa5830a95450008926aba

github-actions · 2023-07-29T13:37:47Z

Parser conformance results on ubuntu-latest

js/262

Test result	`main` count	This PR count	Difference
Total	48863	48863	0
Passed	47810	47808	❌ ⏬ -2
Failed	1053	1055	❌ ⏫ +2
Panics	0	0	0
Coverage	97.84%	97.84%	-0.00%

🔥 Regression (2):

language/statements/labeled/value-await-non-module-escaped.js
language/statements/labeled/value-await-non-module.js

jsx/babel

Test result	`main` count	This PR count	Difference
Total	40	40	0
Passed	37	37	0
Failed	3	3	0
Panics	0	0	0
Coverage	92.50%	92.50%	0.00%

symbols/microsoft

Test result	`main` count	This PR count	Difference
Total	6212	6212	0
Passed	1764	1764	0
Failed	4448	4448	0
Panics	0	0	0
Coverage	28.40%	28.40%	0.00%

ts/babel

Test result	`main` count	This PR count	Difference
Total	639	639	0
Passed	573	573	0
Failed	66	66	0
Panics	0	0	0
Coverage	89.67%	89.67%	0.00%

ts/microsoft

Test result	`main` count	This PR count	Difference
Total	17224	17224	0
Passed	13121	13121	0
Failed	4103	4103	0
Panics	0	0	0
Coverage	76.18%	76.18%	0.00%

nissy-dev · 2023-07-30T08:37:35Z

I checked if rome handle using and await using declaration correctly in playground, but it didn't handle.
I'm looking into what happened.

crates/rome_js_parser/src/syntax/stmt.rs

ematipico · 2023-07-30T09:05:14Z

crates/rome_js_parser/src/syntax/stmt.rs

@@ -1107,7 +1158,7 @@ pub(super) enum VariableDeclarationParent {
    Clause,
 }

-/// Parses a variable declaration that consist of a variable kind (`let`, `const` or `var` and a list
+/// Parses a variable declaration that consist of a variable kind (`let`, `const`, `using` or `var` and a list


The documentation is not correct anymore. The function also checks for await in case of using. We should document this information

ematipico · 2023-07-30T09:19:30Z

I checked if rome handle using and await using declaration correctly in playground, but it didn't handle. I'm looking into what happened.

You have to update parse_declaration_clause too

arendjr

Great job on the tests!

arendjr · 2023-07-30T09:10:50Z

crates/rome_js_analyze/src/analyzers/style/use_single_var_declarator.rs

@@ -52,7 +52,11 @@ impl Rule for UseSingleVarDeclarator {
            semicolon_token,
        } = node.as_fields();

-        let JsVariableDeclarationFields { kind, declarators } = declaration.ok()?.as_fields();
+        let JsVariableDeclarationFields {
+            await_token: _,


I think this token should be added to the rule’s state, so it can be preserved in the fixer action. I had actually made this change here: main...arendjr:rome-tools:using-proposal#diff-b62c2afc841e799795a6707e4bcdf0f415da3b3183303b3a8507d844f546d455R41

Thank you for pointing! I will create a separate PR for some fixes in Linter.

crates/rome_js_parser/src/syntax/stmt.rs

nissy-dev · 2023-07-31T02:55:45Z

Thank you for your reviews! I will try to fix in a few days.

nissy-dev · 2023-08-06T07:57:31Z

You have to update parse_declaration_clause too

I seem "using" cannot be allowed inside a declaration_clause.

https://www.typescriptlang.org/play?ts=5.2.0-beta#code/CYUwxgNghgTiAEBXAzgSwHYHN5QFw-QE8BuAKBAA8AHAexgBck0t4AjeAXiXVADMMQwYkA

nissy-dev · 2023-08-06T08:06:12Z

I update codes by following comments and this PR is ready for the review again!

arendjr

I have no further comments, just the tests are red, but that might've been a network issue affecting CI :)

nissy-dev · 2023-08-07T10:03:34Z

The CI failure is related to PlayForm/Compress#163

Conaclos · 2023-08-07T16:54:27Z

Such a good work!

nissy-dev added 4 commits July 28, 2023 00:28

feat: update CST defination

0aa52cb

feat: support using and await using declaration for parser

2a4a300

feat: support using declaration for formatter

708ed46

Merge branch 'main' into feat-explicit-resource-management

d08c576

github-actions bot added A-Linter Area: linter A-Formatter Area: formatter L-JavaScript Langauge: JavaScript A-Parser Area: parser A-Tooling Area: our own build, development, and release tooling labels Jul 29, 2023

nissy-dev changed the title ~~feat: initial support using and await using declaration~~ feat(rome_js_paerser, rome_js_formatter): initial support using and await using declaration Jul 29, 2023

nissy-dev changed the title ~~feat(rome_js_paerser, rome_js_formatter): initial support using and await using declaration~~ feat(rome_js_parser, rome_js_formatter): initial support using and await using declaration Jul 29, 2023

fix regression

bca19ff

nissy-dev changed the title ~~feat(rome_js_parser, rome_js_formatter): initial support using and await using declaration~~ feat(rome_js_parser, rome_js_formatter): support using and await using declaration Jul 29, 2023

nissy-dev added 2 commits July 30, 2023 17:41

Merge branch 'main' into feat-explicit-resource-management

f1d90c3

update snapshot

6f4990d

ematipico reviewed Jul 30, 2023

View reviewed changes

arendjr reviewed Jul 30, 2023

View reviewed changes

nissy-dev added 3 commits August 6, 2023 00:34

fix: update parser logic with reference to ecma spec

34544c0

fix: update parser logic to pass more prettier tests

5b380f8

fix: update comments

70ac09f

fix: update logic

f4c46bd

arendjr approved these changes Aug 7, 2023

View reviewed changes

ematipico approved these changes Aug 7, 2023

View reviewed changes

ematipico merged commit d25b06d into main Aug 7, 2023
17 of 18 checks passed

ematipico deleted the feat-explicit-resource-management branch August 7, 2023 10:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rome_js_parser, rome_js_formatter): support `using` and `await using` declaration #4737

feat(rome_js_parser, rome_js_formatter): support `using` and `await using` declaration #4737

nissy-dev commented Jul 29, 2023 •

edited

Loading

netlify bot commented Jul 29, 2023 •

edited

Loading

github-actions bot commented Jul 29, 2023 •

edited

Loading

nissy-dev commented Jul 30, 2023

ematipico Jul 30, 2023

ematipico commented Jul 30, 2023

arendjr left a comment

arendjr Jul 30, 2023

nissy-dev Aug 6, 2023 •

edited

Loading

nissy-dev commented Jul 31, 2023

nissy-dev commented Aug 6, 2023

nissy-dev commented Aug 6, 2023 •

edited

Loading

arendjr left a comment •

edited

Loading

nissy-dev commented Aug 7, 2023

Conaclos commented Aug 7, 2023

feat(rome_js_parser, rome_js_formatter): support using and await using declaration #4737

feat(rome_js_parser, rome_js_formatter): support using and await using declaration #4737

Conversation

nissy-dev commented Jul 29, 2023 • edited Loading

Summary

Test Plan

netlify bot commented Jul 29, 2023 • edited Loading

✅ Deploy Preview for docs-rometools canceled.

github-actions bot commented Jul 29, 2023 • edited Loading

Parser conformance results on ubuntu-latest

js/262

jsx/babel

symbols/microsoft

ts/babel

ts/microsoft

nissy-dev commented Jul 30, 2023

ematipico Jul 30, 2023

Choose a reason for hiding this comment

ematipico commented Jul 30, 2023

arendjr left a comment

Choose a reason for hiding this comment

arendjr Jul 30, 2023

Choose a reason for hiding this comment

nissy-dev Aug 6, 2023 • edited Loading

Choose a reason for hiding this comment

nissy-dev commented Jul 31, 2023

nissy-dev commented Aug 6, 2023

nissy-dev commented Aug 6, 2023 • edited Loading

arendjr left a comment • edited Loading

Choose a reason for hiding this comment

nissy-dev commented Aug 7, 2023

Conaclos commented Aug 7, 2023

feat(rome_js_parser, rome_js_formatter): support `using` and `await using` declaration #4737

feat(rome_js_parser, rome_js_formatter): support `using` and `await using` declaration #4737

nissy-dev commented Jul 29, 2023 •

edited

Loading

netlify bot commented Jul 29, 2023 •

edited

Loading

github-actions bot commented Jul 29, 2023 •

edited

Loading

nissy-dev Aug 6, 2023 •

edited

Loading

nissy-dev commented Aug 6, 2023 •

edited

Loading

arendjr left a comment •

edited

Loading