Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Saves not working with IndexedDB #769

Closed
cjwin2000 opened this issue Mar 29, 2024 · 2 comments
Closed

[Bug] Saves not working with IndexedDB #769

cjwin2000 opened this issue Mar 29, 2024 · 2 comments
Labels
bug Something isn't working emulatorjs Emulator.js bugs or feature requests

Comments

@cjwin2000
Copy link

cjwin2000 commented Mar 29, 2024

RomM version
3.03

Describe the bug
When using ingame save functionality (for example pokemon's ingame save on GBA), a save file is not created. Nothing shows in the browser console or network activity. Clicking on the emulatorJS save button creates a save that my browser downloads, but it is not automatically added to RomM, which is what I'm pretty sure the intended functionality is. Save states DO work properly.

To Reproduce
Steps to reproduce the behavior:

  1. Launch a gb, gbc, or gba game that offers in-game save functionality (eg Pokemon leaf green) with built-in emulatorjs
  2. Try to create a save with the ingame save function
  3. Observe nothing happens. No save file is created on the server, there is no browser console activity, and there is no network activity. Comparatively, observe the following:
  4. Now try clicking the "export save file" button and observe that the save file starts to download to the browser's download folder
  5. Now try creating a save state and observe that it is automatically saved to the server

Expected behavior
When using the ingame save mechanic, a save file should be generated and saved to the RomM server.

Screenshots
N/A

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 123.0.6312.86

Smartphone (please complete the following information):

  • Device: iPhone 15
  • OS: iOS 17.3
  • Browser: Safari
  • Version: unsure how to check

Additional context
If any more clarification or information is needed, please let me know

@cjwin2000 cjwin2000 added the bug Something isn't working label Mar 29, 2024
@gantoine gantoine self-assigned this Mar 29, 2024
@gantoine gantoine added the emulatorjs Emulator.js bugs or feature requests label Jul 14, 2024
@gantoine gantoine removed their assignment Aug 29, 2024
@jasonajack
Copy link

jasonajack commented Jan 14, 2025

Seeing the same issue; tested with Firefox and Chrome with the developer tools open and looking for Network activity. Saw the following:

  1. Tried Quick Save in EmulatorJS: no network activity. This is expected because EmuJS does not seem to send quick saves to the server.
  2. Tried Save State from the menu. This worked and I saw two network transfers to the server. Later I did see that the game save states were present in the game menu.
  3. Saved the game from within the game (Chrono Trigger, saved from the map). No network activity was shown and no game saves were present from the game menu in Romm after the fact.

EDIT: this seems related to #786 so I'll look there instead.

@gantoine
Copy link
Member

We're revamping emulatorjs integration in #1497 so i'm rolling this into #786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working emulatorjs Emulator.js bugs or feature requests
Projects
None yet
Development

No branches or pull requests

3 participants