Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working after using example code #49

Open
JPStrydom opened this issue Jul 23, 2018 · 3 comments
Open

Not working after using example code #49

JPStrydom opened this issue Jul 23, 2018 · 3 comments

Comments

@JPStrydom
Copy link

I've followed all the steps in the README but I couldn't get it working. So I resorted to try using the example code found in ./example/firstComp.

I have all the files exactly as they are in the example, and I've added the <link rel="stylesheet" type="text/css" href="../node_modules/react-custom-scroll/dist/customScroll.css"> line to my index HTML file.

Other than that I essentially have a blank CRA project in which I'm only rendering the firstComp component in my index.js file - but my screen still looks like this ->
scrollerror

Any ideas what I'm doing wrong?

@JavierLight
Copy link

I'm just experiencing the same issue, I couldn't get it to work. Importing as stated in documentation does not work.

@rommguy
Copy link
Owner

rommguy commented Nov 21, 2018

Hi @JavierLight and @JPStrydom ,
Thanks for using this library!
I'm unable to reproduce the issue -

It would be very helpful if you can create the case in CodeSandbox or similar and send me the URL
Or, you can try and use chrome dev tools to inspect the space at the top and try to figure out where it is coming from
Thanks!

@jwugit
Copy link

jwugit commented Nov 27, 2018

@rommguy
i know the examples work with flexbox and a fixed height,
but does it work with 100% height and flexbox ?

Basically i have a popup modal that is just width/height 100% absolute, at the body level.
A bunch of nested flex elements then finally react-custom-scroll.

see this sample. sample
if you changed it index.js line 32 to maybe 500px, it works.
Right now it doesnt.

Is this a bug?
something i setup wrong?
something not supported ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants