Merge pull request #34 from ronin-chain/feature/c4-issue-32

feat: address C4's issue#32
ronin-chain · Nov 18, 2024 · e59ece0 · e59ece0
2 parents 03c8017 + c680dc7
commit e59ece0
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 17 deletions.
diff --git a/logs/contract-code-sizes.log b/logs/contract-code-sizes.log
@@ -30,23 +30,23 @@
 | LiquidityAmounts                   |       86 |     24,490 |
 | LiquidityMath                      |       86 |     24,490 |
 | LowGasSafeMath                     |       86 |     24,490 |
-| MixedRouteQuoterV1                 |    7,220 |     17,356 |
-| MixedRouteQuoterV1Testnet          |    7,220 |     17,356 |
+| MixedRouteQuoterV1                 |    7,384 |     17,192 |
+| MixedRouteQuoterV1Testnet          |    7,384 |     17,192 |
 | NFTDescriptor                      |   23,372 |      1,204 |
 | NFTSVG                             |       86 |     24,490 |
-| NonfungiblePositionManager         |   24,120 |        456 |
+| NonfungiblePositionManager         |   24,284 |        292 |
 | NonfungibleTokenPositionDescriptor |    5,097 |     19,479 |
 | Oracle                             |       86 |     24,490 |
 | OracleLibrary                      |       86 |     24,490 |
-| PairFlash                          |    5,428 |     19,148 |
+| PairFlash                          |    5,592 |     18,984 |
 | Path                               |       86 |     24,490 |
 | PoolAddress                        |       86 |     24,490 |
 | PoolTicksCounter                   |       86 |     24,490 |
 | Position                           |       86 |     24,490 |
 | PositionKey                        |       86 |     24,490 |
 | PositionValue                      |       86 |     24,490 |
-| Quoter                             |    3,822 |     20,754 |
-| QuoterV2                           |    7,019 |     17,557 |
+| Quoter                             |    3,986 |     20,590 |
+| QuoterV2                           |    7,183 |     17,393 |
 | SafeCast                           |       86 |     24,490 |
 | SafeERC20Namer                     |       86 |     24,490 |
 | SafeMath                           |       86 |     24,490 |
@@ -55,7 +55,7 @@
 | SqrtPriceMathPartial               |       86 |     24,490 |
 | Strings                            |       86 |     24,490 |
 | SwapMath                           |       86 |     24,490 |
-| SwapRouter                         |    9,945 |     14,631 |
+| SwapRouter                         |   10,109 |     14,467 |
 | Tick                               |       86 |     24,490 |
 | TickBitmap                         |       86 |     24,490 |
 | TickLens                           |    1,322 |     23,254 |

diff --git a/logs/storage/KatanaV3Factory.sol:KatanaV3Factory.log b/logs/storage/KatanaV3Factory.sol:KatanaV3Factory.log
diff --git a/logs/storage/KatanaV3PoolDeployer.sol:KatanaV3PoolDeployer.log b/logs/storage/KatanaV3PoolDeployer.sol:KatanaV3PoolDeployer.log
diff --git a/src/periphery/libraries/CallbackValidation.sol b/src/periphery/libraries/CallbackValidation.sol
@@ -2,6 +2,7 @@
 pragma solidity =0.7.6;
 
 import "src/core/interfaces/IKatanaV3Pool.sol";
+import "src/core/interfaces/IKatanaV3Factory.sol";
 import "./PoolAddress.sol";
 
 /// @notice Provides validation for callbacks from Katana V3 Pools
@@ -31,5 +32,6 @@ library CallbackValidation {
   {
     pool = IKatanaV3Pool(PoolAddress.computeAddress(factory, poolKey));
     require(msg.sender == address(pool));
+    require(msg.sender == IKatanaV3Factory(factory).getPool(poolKey.token0, poolKey.token1, poolKey.fee));
   }
 }