Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: internal audit #32

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix: internal audit #32

merged 2 commits into from
Sep 24, 2024

Conversation

thaixuandang
Copy link
Collaborator

Description

Resolve 2 concerns:

  • Redundant condition in the collect function of NonfungiblePositionManager
  • Remove unused ImmutableState contract

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@thaixuandang thaixuandang merged commit f5bed7f into release/v1.0.0 Sep 24, 2024
@thaixuandang thaixuandang deleted the fix/internal-audit branch October 16, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant