Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move the file argument after flag in init command #6

Merged
merged 1 commit into from
May 8, 2024

Conversation

minh-bq
Copy link
Contributor

@minh-bq minh-bq commented May 8, 2024

Reason

Closes: N/A

What's being changed

We've recently merged a PR to upgrade the cli package to version 2 in Ronin. This version requires the command argument must be after the flags. So this commit edits the init command to follow that rule.

Checklist

  • I've reviewed my changes in a preview environment (click the link in the "Preview" column to view your latest changes).
  • For content changes, I've completed the self-review checklist.

We've recently merged a PR to upgrade the cli package to version 2 in Ronin.
This version requires the command argument must be after the flags. So this
commit edits the init command to follow that rule.
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ronin-document ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 11:21am

Copy link
Contributor

@RodinGolodin RodinGolodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sir

@phuctd95 phuctd95 merged commit d3988a4 into ronin-chain:main May 8, 2024
4 checks passed
@minh-bq minh-bq deleted the fix/init-cmd branch May 9, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants