core: set tip = 0 for system transaction in tracing #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huyngopt1994
approved these changes
Feb 25, 2025
System transaction is not affected by basefee rule in normal flow, the tip from system transaction is always 0. This commit makes the tracing flow consistent with this behavior.
minh-bq
force-pushed
the
fix/debug-api
branch
from
588f47d to
c4523b6
Compare
chiphamskymavis
pushed a commit
that referenced
this pull request
Feb 27, 2025
System transaction is not affected by basefee rule in normal flow, the tip from system transaction is always 0. This commit makes the tracing flow consistent with this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System transaction is not affected by basefee rule in normal flow, the tip from system transaction is always 0. This commit makes the tracing flow consistent with this behavior.