Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual installation guide has a couple of rough edges #20

Open
h14h opened this issue Nov 14, 2024 · 1 comment
Open

Manual installation guide has a couple of rough edges #20

h14h opened this issue Nov 14, 2024 · 1 comment

Comments

@h14h
Copy link

h14h commented Nov 14, 2024

In testing out some SDK 52 issues, I noticed a couple minor rough edges in the manual installation instructions:

  1. The example files use the ~ alias without instructing folks to add it in their tsconfig.json
  2. The guide's Text component is out of date with the current version, and missing react-native-uitextview as a dependency
    • If you later install another component that depends on Text (e.g. Button) via the CLI, and allow it to replace Text, it doesn't install react-native-uitextview

Neither of these is a deal-breaker, but could trip up a beginner.

I can try to set aside some time for a PR if y'all have other priorities.

@h14h
Copy link
Author

h14h commented Nov 14, 2024

I can't find the source for the docs, so I'm not sure I'll be able to create a PR to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant