Skip to content

Commit

Permalink
don't check for fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
cehbrecht committed Oct 30, 2023
1 parent 0f75575 commit 7ea0802
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 13 deletions.
28 changes: 16 additions & 12 deletions rook/director/director.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ def __init__(self, coll, inputs):
self._check_apply_fixes()

def use_fixes(self):
return CONFIG[f"project:{self.project}"].get("use_fixes", False)
# TODO: don't use fixes
return False
# return CONFIG[f"project:{self.project}"].get("use_fixes", False)

def _check_apply_fixes(self):
if (
Expand Down Expand Up @@ -118,20 +120,22 @@ def _resolve(self):
# If we got here: then WPS will be used, because `self.use_original_files == False`

def requires_fixes(self):
if not self.use_fixes():
return False
# TODO: don't use fixes
return False
# if not self.use_fixes():
# return False

if self.search_result:
ds_ids = self.search_result.files()
else:
ds_ids = self.coll
for ds_id in ds_ids:
fix = fixer.Fixer(ds_id)
# if self.search_result:
# ds_ids = self.search_result.files()
# else:
# ds_ids = self.coll
# for ds_id in ds_ids:
# fix = fixer.Fixer(ds_id)

if fix.pre_processor or fix.post_processors:
return True
# if fix.pre_processor or fix.post_processors:
# return True

return False
# return False

def request_aligns_with_files(self):
"""
Expand Down
2 changes: 1 addition & 1 deletion tests/test_director/test_director.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def test_original_files(self):
"/rlds_Amon_INM-CM5-0_ssp245_r1i1p1f1_gr1_201501-210012.nc"
]

@pytest.mark.xfail(reason="not relevant")
@pytest.mark.skip(reason="not relevant")
def test_pre_checked_not_characterised(self):
# raise exception
inputs = {"pre_checked": True}
Expand Down

0 comments on commit 7ea0802

Please sign in to comment.