-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cookiecutter #260
Update cookiecutter #260
Conversation
A few issues:
|
a4c0a5e
to
efc9cd1
Compare
@Zeitsperre the smoke tests only work on a deployed Rook instance with data mounted. I use them to make sure everything is ok after the rook installation. |
I managed to figure out why the docs were failing: It was because almost every library was being mocked in the sphinx configuration, except for If things are looking good here, perhaps we can set ReadTheDocs to build Pull Requests and merge this and #259 ? These will both help with achieving #252. |
@tlvu Let me know if the Docker configuration is good for you! |
@tlvu and @cehbrecht, As far as I'm concerned, this is about as modern as I can make I haven't implemented any major coding convention/style changes yet, but when that happens (upstream), changes will be pushed to all services based on the template. Waiting on approval before starting the update process. |
@Zeitsperre sorry for the review delay. I've been trying get Rocky9 working for our Jenkins and I think I am very close. Should be able to get to this PR by the end of this week. |
@tlvu Hoping to wrap this up. Let me know if anything's missing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Apologies I got side-tracked !
Just some very minor feedback.
Overview
Changes:
Related Issue / Discussion
There's a Pull Request open at bird-house/cookiecutter-birdhouse#120 (waiting on review) to bring the original recipe up to speed. Python3.9 support is already nearing End-of-Life.
Additional Information
This fast-forward is still very behind. This is already a major improvement, though it seems as though the recipe has a few regressions in it; I've done my best to integrate the two.