Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookiecutter #260

Merged
merged 21 commits into from
Oct 22, 2024
Merged

Update cookiecutter #260

merged 21 commits into from
Oct 22, 2024

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Sep 27, 2024

Overview

Changes:

  • Updated the cookiecutter to the latest commit
  • Updated pre-commit to use newer versions and coding conventions
  • Updated the code base with pre-commit
  • Synchronizes dependencies between conda and PyPI

Related Issue / Discussion

There's a Pull Request open at bird-house/cookiecutter-birdhouse#120 (waiting on review) to bring the original recipe up to speed. Python3.9 support is already nearing End-of-Life.

Additional Information

This fast-forward is still very behind. This is already a major improvement, though it seems as though the recipe has a few regressions in it; I've done my best to integrate the two.

@Zeitsperre Zeitsperre self-assigned this Sep 27, 2024
@Zeitsperre
Copy link
Contributor Author

@cehbrecht

A few issues:

  • I think the changes at Copernicus have rendered most of the smoke tests unable to pass. Either that or there's a configuration missing.
  • The docs are failing to build the API due to issues with dependencies. This was already seen in the "latest" builds of the documentation. Not sure how long that has been the case.
  • I think in order to address some of these problems, we need new releases of clisops and daops; This is especially true if we want Python3.12 support.

@cehbrecht
Copy link
Collaborator

@cehbrecht

A few issues:

  • I think the changes at Copernicus have rendered most of the smoke tests unable to pass. Either that or there's a configuration missing.
  • The docs are failing to build the API due to issues with dependencies. This was already seen in the "latest" builds of the documentation. Not sure how long that has been the case.
  • I think in order to address some of these problems, we need new releases of clisops and daops; This is especially true if we want Python3.12 support.

@Zeitsperre the smoke tests only work on a deployed Rook instance with data mounted. I use them to make sure everything is ok after the rook installation.

@Zeitsperre
Copy link
Contributor Author

@cehbrecht

I managed to figure out why the docs were failing: It was because almost every library was being mocked in the sphinx configuration, except for clisops, and since that library relies on the roocs_utils configuration-fetching code, this was not being imported properly and causing really bizarre build errors.

If things are looking good here, perhaps we can set ReadTheDocs to build Pull Requests and merge this and #259 ? These will both help with achieving #252.

@Zeitsperre Zeitsperre requested a review from tlvu October 2, 2024 19:03
@Zeitsperre
Copy link
Contributor Author

@tlvu Let me know if the Docker configuration is good for you!

@Zeitsperre
Copy link
Contributor Author

@tlvu and @cehbrecht,

As far as I'm concerned, this is about as modern as I can make rook before needing to delve into the code base. Waiting on review and approval before this gets merged into #259 and a new version can be released and placed on Docker.

I haven't implemented any major coding convention/style changes yet, but when that happens (upstream), changes will be pushed to all services based on the template.

Waiting on approval before starting the update process.

@tlvu
Copy link
Collaborator

tlvu commented Oct 8, 2024

@Zeitsperre sorry for the review delay. I've been trying get Rocky9 working for our Jenkins and I think I am very close. Should be able to get to this PR by the end of this week.

@Zeitsperre
Copy link
Contributor Author

@tlvu Hoping to wrap this up. Let me know if anything's missing!

Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Apologies I got side-tracked !

Just some very minor feedback.

.github/workflows/main.yml Show resolved Hide resolved
.readthedocs.yml Show resolved Hide resolved
LICENSE Show resolved Hide resolved
Makefile Show resolved Hide resolved
@Zeitsperre Zeitsperre merged commit 3ac9db9 into ci-updates-docker Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants