Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Autolocalization of the "Search" field #12

Open
Ricardo1980 opened this issue Jan 12, 2015 · 1 comment
Open

[Improvement] Autolocalization of the "Search" field #12

Ricardo1980 opened this issue Jan 12, 2015 · 1 comment

Comments

@Ricardo1980
Copy link

It could be used getResources().getString(android.R.string.search_go) so we don't have to localize that string.
Actually I'm learning Android and I don't know how to localize that without modifying your library (which is a bad practice, as I would lose any changes if I update the library from your repo), so I think using the SO strings would be nice in this case.
@thomasdao
Copy link
Contributor

that's very good suggestion 👍 Do you want to send a pull request or work on some existing PR #14? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ricardo1980 @thomasdao