Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property type/subtype #504

Open
kkolotyuk opened this issue Oct 31, 2016 · 1 comment
Open

Property type/subtype #504

kkolotyuk opened this issue Oct 31, 2016 · 1 comment

Comments

@kkolotyuk
Copy link
Contributor

Description

Rollbar contains a lot of empty subtype errors for atleisure: https://rollbar.com/Roomorama/Concierge/items/220/?item_page=0&item_count=100&#instances
Looks like we have problems with atleisure types -> roomorama types mapping.

Possible solutions

Fix current mapping rules:

      case room_type_number
        when 20 # Castle
          property.type    = 'house'
          property.subtype = 'chateau'
        when 30 # Cottage
          property.type    = 'house'
          property.subtype = 'cottage'
        when 40 # Mansion
          property.type    = 'house'
        when 50 # Villa
          property.type    = 'house'
          property.subtype = 'villa'
        when 60 # Chalet
          property.type    = 'house'
        when 80 # Bungalow
          property.type    = 'house'
          property.subtype = 'bungalow'
        when 110, 112 # Studio, Duplex
          property.type    = 'apartment'
          property.subtype = 'studio_bachelor'
        when 120 # Penthouse
          property.type    = 'apartment'
          property.subtype = 'luxury_apartment'
        when 140 # Lodge
          property.type    = 'house'
          property.subtype = 'cabin'
        when 160 # Apartment
          property.type    = 'apartment'
        when 70, 90, 95, 100, 145, 150, 170 # Farmhouse, Boat, House Boat, Holiday Home, Riad, Mobile Home, Cave house
          property.type    = 'house'
      end

Occurrences

  • #698101 this one has 160 atleisure type code
  • #698095 this one has 100 atleisure type code
@kkolotyuk
Copy link
Contributor Author

@keang I remember you fixed something like this, could you please review this issue, or give me a list of valid types/subtypes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant