From 34e257008d3f8c0701b519f5d1db76f1358f4e6e Mon Sep 17 00:00:00 2001 From: Jonathan Carroll Date: Sun, 18 Apr 2021 10:16:56 +0930 Subject: [PATCH] get_historical_weather throws an error, examples disabled --- DESCRIPTION | 2 +- NEWS.md | 4 ++++ R/get_historical_weather.R | 9 ++++++++- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index dc1162e1..f267c4f1 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Package: bomrang Type: Package Title: Australian Government Bureau of Meteorology ('BOM') Data Client -Version: 0.7.4.9000 +Version: 0.7.4.9001 Authors@R: c(person(given = "Adam H.", family = "Sparks", diff --git a/NEWS.md b/NEWS.md index 297f674a..797cdc4d 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,9 @@ # bomrang (development version) +# bomrang 0.7.5 + +* `get_historical_weather()` has been disabled due to changes by BOM. See https://github.com/ropensci/bomrang/discussions/141 + # bomrang 0.7.4 ## Bug fixes diff --git a/R/get_historical_weather.R b/R/get_historical_weather.R index 0fd96e45..008dcc2e 100644 --- a/R/get_historical_weather.R +++ b/R/get_historical_weather.R @@ -87,7 +87,8 @@ #' @author Jonathan Carroll, \email{rpkg@@jcarroll.com.au} #' #' @examples -#' \donttest{ +#' \dontrun{ +#' ## these are currently not functional due to BOM changes #' get_historical_weather(stationid = "023000", #' type = "max") ## ~48,000+ daily records #' get_historical_weather(latlon = c(-35.2809, 149.1300), @@ -101,6 +102,12 @@ get_historical_weather <- get_historical <- latlon = NULL, radius = NULL, type = c("rain", "min", "max", "solar")) { + + stop("Due to recent changes by the BOM, this functionality is temporarily disabled. + Refer to http://reg.bom.gov.au/other/copyright.shtml + and + https://github.com/ropensci/bomrang/discussions/141") + site <- ncc_obs_code <- NULL #nocov if (is.null(stationid) & is.null(latlon))