Replace the internal data store variables with immutable collections

[jacknoble]

from https://github.com/facebook/immutable-js

[rorysaur]

👍

[jacknoble]

It may not be strictly necessary but this library is written in ES6 and all the documentation/examples use ES6. What do we think about switching? Personally I'd like to do it after we develop a bit more, I think it would be a good way to learn to convert a whole app over.

[rorysaur]

yes i would like to ES6 with a transpiler like babelify.

[satishkunisi]

This relates to #60 and the 'two children with the same key' warning. Currently:

1. ChannelMessages init's listenForNewMessages for target channel
2. MessageStore listens for the NEW_MESSAGE action
3. MessageStore adds each message to the store
4. ChannelMessages unmounts, then remounts firing listenForNewMessages again
5. MessageStore again receives the NEW_MESSAGE action and adds the duplicate messages to the store

Either loading messages all at once or checking for dups would seem to fix this issue.

[jacknoble]

Ohhhh, that explains it. Nice job tracking it down. Fucking firebase...

[rorysaur]

why does it unmount and remount?

[satishkunisi]

When the router transitions to another component the current component
unmounts. It remounts when you transition back to it. Chat -> About -> Chat

On Friday, April 3, 2015, Rory Ou [email protected] wrote:

why does it unmount and remount?

—
Reply to this email directly or view it on GitHub
#21 (comment).

Sent from Gmail Mobile