Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup controller config #232

Merged

Conversation

christophfroehlich
Copy link
Contributor

The controller config of the velocity and effort controllers (specializations of the forward_command_controller) had some non-existing parameters in the yaml.

See the config files in the demo repository or the PR to update the docs.

@christophfroehlich christophfroehlich changed the title Fix controller config Cleanup controller config Sep 6, 2023
@ahcorde ahcorde merged commit 934621e into ros-controls:master Sep 6, 2023
@christophfroehlich
Copy link
Contributor Author

Thanks! Could you also backport it to humble please?

@ahcorde
Copy link
Collaborator

ahcorde commented Sep 7, 2023

https://github.com/Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 7, 2023
* Remove wrong yaml entries

* Rename effort_controller

(cherry picked from commit 934621e)
ahcorde pushed a commit that referenced this pull request Sep 7, 2023
* Remove wrong yaml entries

* Rename effort_controller

(cherry picked from commit 934621e)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@christophfroehlich christophfroehlich deleted the fix_controller_config branch October 2, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants