Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Derivative Gain for Position Command #377

Closed
Tiz000 opened this issue Jul 29, 2024 · 4 comments
Closed

Missing Derivative Gain for Position Command #377

Tiz000 opened this issue Jul 29, 2024 · 4 comments

Comments

@Tiz000
Copy link

Tiz000 commented Jul 29, 2024

Currently, the gz_ros2_control package implements only a proportional gain control for position commands.
Is there a specific reason why only proportional gain is implemented without derivative gain in the position control strategy?

@christophfroehlich
Copy link
Contributor

Afaik the proportional gain is just added to make the physics engine work. Control tasks should be implemented in your ros2_controller.
A different topic, PIDs for effort interfaces
#306

@Tiz000
Copy link
Author

Tiz000 commented Jul 29, 2024

I understand that, but I don't want to add my control tasks into the plugin, I would like to implement a better way in which position commands are sent to the joints to simulate the internal dynamic of my motors and make the simulation more realistic. Thanks for your fast response.

@christophfroehlich
Copy link
Contributor

I would like to implement a better way in which position commands are sent to the joints to simulate the internal dynamic of my motors and make the simulation more realistic.

That's exactly what the linked PR wants to achieve. Contributions are very welcome :)

@Tiz000
Copy link
Author

Tiz000 commented Jul 31, 2024

Thank you so much

@Tiz000 Tiz000 closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants