Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller manager name matches container name in composable nodes #441

Closed
Tacha-S opened this issue Nov 28, 2024 · 0 comments · Fixed by #482
Closed

Controller manager name matches container name in composable nodes #441

Tacha-S opened this issue Nov 28, 2024 · 0 comments · Fixed by #482

Comments

@Tacha-S
Copy link
Contributor

Tacha-S commented Nov 28, 2024

As mentioned in this comment,
when launching gz_server with composable nodes, the node options passed to the controller manager include the container's name or namespace.

This results in the controller manager forcibly inheriting the same name as the container node.

this->dataPtr->controller_manager_.reset(
new controller_manager::ControllerManager(
std::move(resource_manager_),
this->dataPtr->executor_,
controllerManagerNodeName,
this->dataPtr->node_->get_namespace(), options));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant