Adapt API style of lock_memory to match the one of the other functions #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
christophfroehlich,
livanov93,
LukasMacha97,
olivier-stasse,
progtologist and
rosterloh
|
This is API breaking. I prefer to have a proper deprecation |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #209 +/- ##
==========================================
- Coverage 73.42% 72.55% -0.88%
==========================================
Files 7 7
Lines 414 419 +5
Branches 68 68
==========================================
Hits 304 304
- Misses 68 73 +5
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@saikishor That's a very good point I missed out. I adapted the PR accordingly. |
saikishor
approved these changes
Nov 28, 2024
christophfroehlich
approved these changes
Nov 28, 2024
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
#209) Co-authored-by: Lennart Nachtigall <[email protected]> (cherry picked from commit 069df6d)
christophfroehlich
pushed a commit
that referenced
this pull request
Dec 10, 2024
…s (backport #209) (#229) Adapt API style of lock_memory to match the one of the other functions (#209) Co-authored-by: Lennart Nachtigall <[email protected]> (cherry picked from commit 069df6d) Co-authored-by: Lennart Nachtigall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the API style of the lock_memory function to match the style of the other methods.
I will create a PR that adapts the usage in ros2 control:
https://github.com/search?q=repo%3Aros-controls%2Fros2_control%20lock_memory&type=code
Which is also the only place it is currently used:
https://github.com/search?q=realtime_tools%3A%3Alock_memory&type=code