Apply suggestions from code review

Co-authored-by: Bence Magyar <[email protected]>
ros-controls · Dec 4, 2024 · c910761 · c910761
1 parent fc70a00
commit c910761
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/joint_limits/CMakeLists.txt b/joint_limits/CMakeLists.txt
@@ -108,7 +108,7 @@ if(BUILD_TESTING)
     rclcpp
   )
 
-  ament_add_gtest(test_joint_range_limiter test/test_joint_range_limiter.cpp)
+  ament_add_gmock(test_joint_range_limiter test/test_joint_range_limiter.cpp)
   target_include_directories(test_joint_range_limiter PRIVATE include)
   target_link_libraries(test_joint_range_limiter joint_limiter_interface)
   ament_target_dependencies(
@@ -117,7 +117,7 @@ if(BUILD_TESTING)
     rclcpp
   )
 
-  ament_add_gtest(test_joint_soft_limiter test/test_joint_soft_limiter.cpp)
+  ament_add_gmock(test_joint_soft_limiter test/test_joint_soft_limiter.cpp)
   target_include_directories(test_joint_soft_limiter PRIVATE include)
   target_link_libraries(test_joint_soft_limiter joint_limiter_interface)
   ament_target_dependencies(

diff --git a/joint_limits/src/joint_saturation_limiter.cpp b/joint_limits/src/joint_saturation_limiter.cpp
@@ -433,10 +433,8 @@ bool JointSaturationLimiter<trajectory_msgs::msg::JointTrajectoryPoint>::on_enfo
 
 // typedefs are needed here to avoid issues with macro expansion. ref:
 // https://stackoverflow.com/a/8942986
-typedef std::map<int, int> int_map;
-typedef joint_limits::JointSaturationLimiter<trajectory_msgs::msg::JointTrajectoryPoint>
-  JointTrajectoryPointSaturationLimiter;
-typedef joint_limits::JointLimiterInterface<trajectory_msgs::msg::JointTrajectoryPoint>
-  JointTrajectoryPointLimiterInterfaceBase;
+using int_map = std::map<int, int>;
+using JointTrajectoryPointSaturationLimiter = joint_limits::JointSaturationLimiter<trajectory_msgs::msg::JointTrajectoryPoint>;
+using JointTrajectoryPointLimiterInterfaceBase = joint_limits::JointLimiterInterface<trajectory_msgs::msg::JointTrajectoryPoint>;
 PLUGINLIB_EXPORT_CLASS(
   JointTrajectoryPointSaturationLimiter, JointTrajectoryPointLimiterInterfaceBase)