-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot unload unconfigured controller #1136
Comments
@saikishor or someone else. Sorry to push. But I think this issue should not be forgotten. |
@firesurfer thanks for the reminder. If I have some time during this or next week, I'll try to fix it |
@firesurfer I tried to reproduce your error. I see the same error message but at the end of the day, it does get removed from the controller list. It's just that the node cleanup is only needed if the controller is in an inactive state, if it is in unconfigured state, this won't be needed. |
@firesurfer I've created a pull request with the fix |
@saikishor Okey good to know. I just tried to unload the controller and saw the error message. |
@firesurfer can you test the PR #1363 and if it works, please approve it. So, we can get it merged and backport it |
Describe the bug
When having an erronous controller which can not be configured it is left in the state
unconfigured
.When trying to unload that controller there is no rcl life cycle transition found
To Reproduce
ros2 control unload_controller my_bad_controller
Expected behavior
Being able to unload the controller
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: