Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

view_controller_chains does not work with example #1095

Open
christophfroehlich opened this issue Aug 7, 2023 · 4 comments · May be fixed by #2026
Open

view_controller_chains does not work with example #1095

christophfroehlich opened this issue Aug 7, 2023 · 4 comments · May be fixed by #2026
Labels
bug

Comments

@christophfroehlich
Copy link
Contributor

christophfroehlich commented Aug 7, 2023 •
edited
Loading

Describe the bug
The output of view_controller_chains does not seem to work with the new example 12 of the demo repository.

To Reproduce
Steps to reproduce the behavior:

  1. Checkout https://github.com/ros-controls/ros2_control_demos/
  2. Run the example 12 as written in the doc
  3. ros2 control view_controller_chains

Expected behavior
Some chain in the PDF.

Screenshots
But there are no links, just nodes:
controller_diagram.gv.pdf

Environment (please complete the following information):

  • OS: Ubuntu 22.04
  • Version: Rolling

Additional context
none
@christophfroehlich
Copy link
Contributor Author

@pac48 could you please have a look on that if you find time?

@christophfroehlich christophfroehlich mentioned this issue Aug 7, 2023
Merged
@pac48
Copy link
Contributor

pac48 commented Aug 11, 2023

I was able to reproduce the error that you mentioned. It seems that the Python library was changed from graphviz to pygraphviz in this PR #812 When I run with the old graphviz way, I get this output.
Screenshot from 2023-08-11 15-36-46
I am not too familiar with the differences between graphviz and pygraphviz, but it seems there is a difference in usage.

Is it possible to get a diagram of what the output should look like? The output above doesn't seem right.

@christophfroehlich
Copy link
Contributor Author

I haven't seen the changes from your version, sorry. Maybe @sachinkum0009 can have a look?

@saikishor designed the example, imho the graph posted above isn't correct?

@bmagyar
Copy link
Member

bmagyar commented Aug 12, 2023

I believe the motivation for using a different graphviz python implementation was that the former isn't supported by rosdep

This was referenced Jan 31, 2025
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix view_controller_chains ros-controls/ros2_control
3 participants
@christophfroehlich @bmagyar @pac48