Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger coverage build on the master branch #1119

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Trigger coverage build on the master branch #1119

merged 2 commits into from
Sep 21, 2023

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Sep 20, 2023

No description provided.

@bmagyar bmagyar requested a review from destogl September 20, 2023 18:03
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #1119 (3c29425) into master (a6a86d4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1119   +/-   ##
=======================================
  Coverage   31.83%   31.83%           
=======================================
  Files          94       94           
  Lines       10483    10483           
  Branches     7136     7136           
=======================================
  Hits         3337     3337           
  Misses        801      801           
  Partials     6345     6345
Flag Coverage Δ
unittests 31.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@christophfroehlich
Copy link
Contributor

Codecov Report

Merging #1119 (349cb61) into master (a6a86d4) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

this looks fine now 👍

@destogl @fmauch
Apply suggestions from code review
3c29425 
Co-authored-by: Felix Exner (fexner) <[email protected]>
@destogl
Copy link
Member

destogl commented Sep 20, 2023

thanks @fmauch

saikishor
saikishor approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmagyar bmagyar merged commit d77f6f1 into master Sep 21, 2023
1 check passed
@christophfroehlich christophfroehlich mentioned this pull request Sep 26, 2023
Merged
@bmagyar bmagyar deleted the run-codecov-on-master-after-merges branch December 4, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch left review comments

@aprotyas aprotyas aprotyas approved these changes

@saikishor saikishor saikishor approved these changes

@destogl destogl destogl approved these changes

@duringhof duringhof Awaiting requested review from duringhof

@livanov93 livanov93 Awaiting requested review from livanov93

@malapatiravi malapatiravi Awaiting requested review from malapatiravi

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bmagyar @christophfroehlich @destogl @fmauch @saikishor @aprotyas