Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the spamming checking interface ERROR to DEBUG #1605

Conversation

saikishor
Copy link
Member

@christophfroehlich pointed out that there is a spamming error of "Checking interface" while starting the controllers, this was not meant to be ERROR log, rather it must be a DEBUG log, it was introduced accidentally with #1021 changes.

Thank you for pointing it out @christophfroehlich

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fair ;-)

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ;)

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.29%. Comparing base (723c869) to head (0d25c44).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1605   +/-   ##
=======================================
  Coverage   87.29%   87.29%           
=======================================
  Files         108      108           
  Lines        9793     9793           
  Branches      886      886           
=======================================
  Hits         8549     8549           
  Misses        925      925           
  Partials      319      319           
Flag Coverage Δ
unittests 87.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/src/controller_manager.cpp 75.72% <ø> (ø)

@destogl destogl merged commit 5be9d17 into ros-controls:master Jul 8, 2024
20 checks passed
@saikishor saikishor deleted the fix/spamming_check_interface_log_to_debug branch August 17, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants