Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional reusable workflows #7

Closed
3 tasks done
christophfroehlich opened this issue Feb 17, 2024 · 0 comments
Closed
3 tasks done

Additional reusable workflows #7

christophfroehlich opened this issue Feb 17, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@christophfroehlich
Copy link
Contributor

christophfroehlich commented Feb 17, 2024

A great advantage of the central reusable workflows is that we reduce dependabot-commits in the other repos. But there are some workflows here missing

Some hints

  • The list of packages can be parsed like I did with here
    - name: Get list of packages
    # we need both paths, there is no wildcard/glob for packages defined in the root folder and subfolders at the same time
    run: |
    echo "REPO_NAME=$(echo ${{ github.repository }} | cut -d '/' -f 2)" >> $GITHUB_ENV
    echo "package_list=$(colcon list --paths ${{ env.path }} --names-only | tr '\n' ' ') $(colcon list --paths ${{ env.path }}/* --names-only | tr '\n' ' ')" >> $GITHUB_ENV
    echo "repo ${{ env.REPO_NAME}} has packages: ${{ env.package_list }}"
  • For the format + ros-lint we maybe should not use ubuntu-latest but always the explicit version from REP-2000? (make an input for the os-version and specify that from the calling workflows from the repos)
@christophfroehlich christophfroehlich added the help wanted Extra attention is needed label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant