Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reusable workflow for coverage build #12

Merged
merged 10 commits into from
Feb 21, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Feb 18, 2024

Uses the composite action introduced with #11

I'm not sure if we need the CODECOV_TOKEN:
https://github.com/codecov/codecov-action/blob/e0b68c6749509c5f83f984dd99a76a1c1a231044/action.yml#L5-L7
In some repositories we use it, in some we don't.
I tried adding it as described here but got errors from the caller workflow from my fork (where I don't have/need this token).

This was tested successfully with ros-controls/control_toolbox#188

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and seems to run fine.

@christophfroehlich christophfroehlich marked this pull request as ready for review February 21, 2024 20:48
@christophfroehlich christophfroehlich merged commit 1d61b35 into master Feb 21, 2024
2 checks passed
@christophfroehlich christophfroehlich deleted the ci_coverage_build branch February 21, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants