Skip to content

Commit

Permalink
Remove RegisterEventHandlers
Browse files Browse the repository at this point in the history
  • Loading branch information
christophfroehlich committed Sep 28, 2024
1 parent 1752c83 commit 77515bf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 31 deletions.
11 changes: 1 addition & 10 deletions example_15/bringup/launch/rrbot_base.launch.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,20 +226,11 @@ def generate_launch_description():
)
)

# Delay start of joint_state_broadcaster after `robot_controller`
# TODO(anyone): This is a workaround for flaky tests. Remove when fixed.
delay_joint_state_broadcaster_after_robot_controller_spawner = RegisterEventHandler(
event_handler=OnProcessExit(
target_action=robot_controller_spawner,
on_exit=[joint_state_broadcaster_spawner],
)
)

nodes = [
control_node,
robot_state_pub_node,
robot_controller_spawner,
delay_joint_state_broadcaster_after_robot_controller_spawner,
joint_state_broadcaster_spawner,
delay_rviz_after_joint_state_broadcaster_spawner,
]

Expand Down
23 changes: 2 additions & 21 deletions example_15/bringup/launch/rrbot_namespace.launch.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,32 +131,13 @@ def generate_launch_description():
)
)

# Delay start of joint_state_broadcaster after `robot_controller`
# TODO(anyone): This is a workaround for flaky tests. Remove when fixed.
delay_joint_state_broadcaster_after_robot_controller_spawner = RegisterEventHandler(
event_handler=OnProcessExit(
target_action=robot_forward_position_controller_spawner,
on_exit=[joint_state_broadcaster_spawner],
)
)

# Delay start of robot_controller after `joint_state_broadcaster`
delay_robot_position_trajectory_controller_spawner_after_joint_state_broadcaster_spawner = (
RegisterEventHandler(
event_handler=OnProcessExit(
target_action=joint_state_broadcaster_spawner,
on_exit=[robot_position_trajectory_controller_spawner],
)
)
)

nodes = [
control_node,
robot_state_pub_node,
delay_rviz_after_joint_state_broadcaster_spawner,
robot_forward_position_controller_spawner,
delay_joint_state_broadcaster_after_robot_controller_spawner,
delay_robot_position_trajectory_controller_spawner_after_joint_state_broadcaster_spawner,
joint_state_broadcaster_spawner,
robot_position_trajectory_controller_spawner,
]

return LaunchDescription(declared_arguments + nodes)

0 comments on commit 77515bf

Please sign in to comment.