Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple_message header changes #62

Open
GoogleCodeExporter opened this issue Apr 7, 2015 · 12 comments
Open

simple_message header changes #62

GoogleCodeExporter opened this issue Apr 7, 2015 · 12 comments

Comments

@GoogleCodeExporter
Copy link

I have attached a patch which should make extending simple_messages actually 
possible.  Basically, I have added a few more compile definitions which 
separate honest MOTOPLUS and ROS header definitions from their real 
functionality.  I couldn't use them, as-is, because I had to define one or the 
other for the includes to work, but they both had libraries that don't exist on 
the Universal control box.  Here should be a list of all of the new/existing 
compile definitions:

    FLATHEADERS - If defined, it removes the "simple_message" prefix.  The MotoPlus controller should define this, but not ROS.
    LINUXSOCKETS - If defined, uses the basic Linux sockets for communication.  ROS should define this, Motoplus should not.
    ROS - Only used in places where the "ros/ros.h" header is, I think.  Used in the logging file.
    MOTOPLUS - Only used in places where the "motoplus.h" header is, I think.  Used for the logging and communication changes.
    STDIOLOG - Used in the logger to enable the "printf" logging which had been disabled in the MOTOPLUS definition block.  Shouldn't be defined on either ROS or MotoPlus.
    FLOAT64, INT32, INT64 - Used to enable 64-bit floats instead of 32-bit floats.  The documentation for the shared_types file isn't really accurate.  The architecture of the machine (32bit/64bit) doesn't determine the float/int size, it's the compiler/system.  I have included these flags so that you can manually define the size of the floats and ints in shared_types.  If you don't define any of these flags, it reverts to the previous behavior.

This patch is based on revision r1349, so it should be fairly up to date.  If 
someone can add the FLATHEADERS compiler definition to the MotoPlus controller 
and test my changes, we'll be one step towards making simple_messages more 
portable.

-Kelsey

Original issue reported on code.google.com by [email protected] on 21 May 2013 at 8:22

Attachments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant