Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve verification of outbound EGM commands #69

Closed
jontje opened this issue Jan 31, 2020 · 1 comment · Fixed by #83
Closed

Improve verification of outbound EGM commands #69

jontje opened this issue Jan 31, 2020 · 1 comment · Fixed by #83
Assignees
@jontje
Labels
enhancement New feature or request

Comments

@jontje
Copy link
Contributor

jontje commented Jan 31, 2020 •
edited by gavanderhoorn
Loading

As mentioned in PR #68, then there is currently no check in abb_libegm for NaN values. If NaN values are allowed to pass to the robot controller, then this will cause a system failure.

It should be straight-forward to add checks for NaN to the methods here and here.
@jontje jontje added the enhancement New feature or request label Jan 31, 2020
@jontje jontje self-assigned this Jan 31, 2020
@gavanderhoorn
Copy link
Member

@jontje: I've replaced the links with perma-links.

@gavanderhoorn gavanderhoorn mentioned this issue Jan 31, 2020
Closed
@jontje jontje mentioned this issue Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jontje jontje

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Verify outbound values jontje/abb_libegm
2 participants
@gavanderhoorn @jontje