-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle industrial_ci, if run from act #743
Bundle industrial_ci, if run from act #743
Conversation
@ipa-mdl thanks for this this! It is working! I am using the following configuration (example tested with ros-controls/ros2_control repository):
|
If this works you might want to 'advertise' it a little @ipa-mdl. Could save tenths of notifications each day by people pushing "fixup" and "test CI" commits (as they could now run it locally). And GHA minutes, actually. They're not free (well, they are, but they are limited, depending on the plan you have). |
@ipa-mdl do you want to write short “manual” or should I. I will be glad to review it at lest 🤖 |
It would be great if you could draft one. |
85eb938
to
ba1d360
Compare
434b25d
to
40398a3
Compare
@gavanderhoorn: Together with #590 and #749, because the workflow syntax might need to be changed |
in what way? You mean configs need to be changed to no longer use the |
@gavanderhoorn: Away from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ipa-mdl I proposed two extra refinements in .rst file for proper rendering.
8742edf
to
d070216
Compare
.github/action.sh
Outdated
@@ -42,4 +42,9 @@ if [ "${ABICHECK_MERGE:-}" = "auto" ]; then | |||
[ "$GITHUB_EVENT_NAME" != "pull_request" ] || ABICHECK_MERGE=true | |||
fi | |||
|
|||
env "$@" bash "$DIR_THIS/../industrial_ci/src/ci_main.sh" | |||
if [[ $ICI_SRC_PATH == *run/act/* ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to relax this test a little bit. Not sure why, but in one of my tests it was /run/act
instead of /var/run/act
.
d070216
to
05352cc
Compare
No description provided.