Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle industrial_ci, if run from act #743

Merged

Conversation

mathias-luedtke
Copy link
Member

No description provided.

@destogl
Copy link
Contributor

destogl commented Sep 22, 2021

@ipa-mdl thanks for this this! It is working!

I am using the following configuration (example tested with ros-controls/ros2_control repository):

jobs:
  ci_binary:
    name: Galactic binary job
    runs-on: ubuntu-latest
    strategy:
      matrix:
        env:
          - {ROS_DISTRO: galactic, ROS_REPO: main}
          - {ROS_DISTRO: galactic, ROS_REPO: testing}
    steps:
      - uses: actions/checkout@v1
      - uses: ipa-mdl/industrial_ci@feature/act-support
        with:
          config: ${{toJSON(matrix.env)}}

@gavanderhoorn
Copy link
Member

gavanderhoorn commented Sep 22, 2021

If this works you might want to 'advertise' it a little @ipa-mdl.

Could save tenths of notifications each day by people pushing "fixup" and "test CI" commits (as they could now run it locally).


And GHA minutes, actually. They're not free (well, they are, but they are limited, depending on the plan you have).

@destogl
Copy link
Contributor

destogl commented Sep 22, 2021

@ipa-mdl do you want to write short “manual” or should I. I will be glad to review it at lest 🤖

@mathias-luedtke
Copy link
Member Author

do you want to write short “manual” or should I.

It would be great if you could draft one.

@mathias-luedtke mathias-luedtke added the wrid21 World ROS-Industrial Day 2021 label Sep 27, 2021
@mathias-luedtke mathias-luedtke marked this pull request as ready for review October 7, 2021 17:16
@mathias-luedtke mathias-luedtke force-pushed the feature/act-support branch 2 times, most recently from 85eb938 to ba1d360 Compare October 7, 2021 17:29
@mathias-luedtke mathias-luedtke force-pushed the feature/act-support branch 3 times, most recently from 434b25d to 40398a3 Compare October 7, 2021 17:47
@mathias-luedtke
Copy link
Member Author

@destogl: I had to rewrite your Markdown syntax to reStructeredText (I always forget about this as well, #750), please review the resulting layout.

@mathias-luedtke
Copy link
Member Author

If this works you might want to 'advertise' it a little @ipa-mdl.

@gavanderhoorn: Together with #590 and #749, because the workflow syntax might need to be changed

@gavanderhoorn
Copy link
Member

If this works you might want to 'advertise' it a little @ipa-mdl.

@gavanderhoorn: Together with #590 and #749, because the workflow syntax might need to be changed

in what way? You mean configs need to be changed to no longer use the matrix: ${{ toJSON(matrix) }} syntax?

@mathias-luedtke
Copy link
Member Author

in what way? You mean configs need to be changed to no longer use the matrix: ${{ toJSON(matrix) }} syntax?

@gavanderhoorn: Away from ${{ matrix.env }}, either by passing all env entries explicitly (recommended for simple cases) or by using config: ${{toJSON(matrix)}}

Copy link
Contributor

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ipa-mdl I proposed two extra refinements in .rst file for proper rendering.

doc/index.rst Outdated Show resolved Hide resolved
doc/index.rst Outdated Show resolved Hide resolved
@mathias-luedtke mathias-luedtke force-pushed the feature/act-support branch 2 times, most recently from 8742edf to d070216 Compare November 11, 2021 22:01
@@ -42,4 +42,9 @@ if [ "${ABICHECK_MERGE:-}" = "auto" ]; then
[ "$GITHUB_EVENT_NAME" != "pull_request" ] || ABICHECK_MERGE=true
fi

env "$@" bash "$DIR_THIS/../industrial_ci/src/ci_main.sh"
if [[ $ICI_SRC_PATH == *run/act/* ]]; then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to relax this test a little bit. Not sure why, but in one of my tests it was /run/act instead of /var/run/act.

@mathias-luedtke mathias-luedtke merged commit 84e54ad into ros-industrial:master Nov 12, 2021
@mathias-luedtke mathias-luedtke deleted the feature/act-support branch November 12, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wrid21 World ROS-Industrial Day 2021
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants