Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Qt Creator 4.9 #342

Closed
wants to merge 1 commit into from
Closed

Conversation

iohanaan
Copy link

No description provided.

@iohanaan
Copy link
Author

Address issue #335

@gavanderhoorn
Copy link
Member

I'm always amazed by the nr of (breaking) changes the Qt (Creator) devs introduce in new minor versions.

It's obviously positive that they keep working on their product, but it makes the life of plugin maintainers so much harder.

@Levi-Armstrong
Copy link
Member

@iohanaan Thank you for your contribution. I should be able to pull it down this week and test it and provide feedback if necessary.

@vincent-hui
Copy link

@Levi-Armstrong will you submit ROS plugin to the Qt Creator source on codereview.qt-project.org ? You can save time consuming effort to adapt it to API changes.
#325

@Levi-Armstrong
Copy link
Member

Levi-Armstrong commented May 31, 2019

@Levi-Armstrong will you submit ROS plugin to the Qt Creator source on codereview.qt-project.org ? You can save time consuming effort to adapt it to API changes.

I agree it would be nice, but the code is not to a state that would be acceptable. It does not conform the there style guide and it is not cross platform. It would require more effort than I have at the moment to get the code up to standard where I would feel comfortable submitting. This does not prevent others though from submitting it and addressing all request changes to get it merged.

@Levi-Armstrong
Copy link
Member

merged in #342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants