-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bloom config is hardcoded to look at master branch new repositories use main as default #721
Comments
Another workaround available to maintainers is to sync main to master. You can use this action to keep main and master in sync and bloom would use the synced version. https://github.com/zofrex/mirror-branch I've used it here: https://github.com/osrf/rocker/blob/main/.github/workflows/mirror-main-to-master.yaml |
I think this is probably more painful, and we can pretty easily figure out what the default branch is from git. A command like: |
We just had a chance to chat about this. We used to use use the We would like to go back to using the When we deploy new ros2-gbp repositories via terraform it creates an empty repository that bloom will eventually push to. Github won't let us set the default branch until the branch is created. The default branch defaults to the first one pushed, which if bloom does it, will be For now we should stick with the expectation that the default branch in a release repo should be |
Places where people have run into problems: |
When people try to add config options such as
.ignored
files bloom doesn't find them, if they have a more recent repository withmain
as the default. Legacy repositories work fine because they still default tomaster
as the default branch.Example problem ros/rosdistro#39536
The branch is hard coded here:
bloom/bloom/config.py
Line 62 in d3d21ae
It would be good to change this to detect and use the default branch in the repository and allow an override if there's a specific branch desired by the maintainer. The simpler solution would be to allow overriding it on the command line only.
The text was updated successfully, but these errors were encountered: