Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease web tool quietly fails when given empty entries #48

Open
mxgrey opened this issue Mar 13, 2018 · 4 comments
Open

Prerelease web tool quietly fails when given empty entries #48

mxgrey opened this issue Mar 13, 2018 · 4 comments

Comments

@mxgrey
Copy link

mxgrey commented Mar 13, 2018

If you want to test a prerelease of a repo that has not already been added to the ros distro, you need to include at least existing repo to the list, or else you cannot proceed past step 2.

For people trying to test a prerelease of one or more new repos before adding them to a distro, it would be useful if the tool could work with just a list of custom repositories.

To recreate this issue, simply run the web tool and only add a custom repository. The tool will quietly freeze when you attempt to click Next at the second step.

@wjwwood
Copy link
Contributor

wjwwood commented Mar 13, 2018

I believe you can add a custom repository and remove the default first entry and then you don't need anything to be released.

@mikaelarguedas
Copy link
Contributor

I believe you can add a custom repository and remove the default first entry and then you don't need anything to be released.

👍 just tried it, the issue seems to be the default empty entry that prevent to go to the next step.

Though this issue is still valuable as we should probably fail in a louder way when this happens

@mxgrey
Copy link
Author

mxgrey commented Mar 13, 2018

It should probably freeze at the first Next and highlight that first entry with a suggestion to either fill it in or delete it before proceeding.

@wjwwood
Copy link
Contributor

wjwwood commented Mar 13, 2018

Yeah, that would be better, currently it just has a JS error on the next button of the second page. We could also just make the JS code robust to empty entries.

@mxgrey mxgrey changed the title Prerelease web tool requires at least one released repo Prerelease web tool quietly fails when given empty entries Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants