Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rosdep install should have an --update flag to refresh package cache before performing install #904

Open
codygarver opened this issue Oct 27, 2022 · 4 comments

Comments

@codygarver
Copy link

Our use case is in CI we use containers whose apt package cache is often stale, causing rosdep install to eventually fail unless apt-get update has run recently.

I propose that rosdep install should have an --update flag that will refresh the package cache if the backend package manager supports that. The equivalent of running apt-get update && rosdep install foo.

@peci1
Copy link

peci1 commented Jan 2, 2023

I don't think this is a job for rosdep.

You should ensure re-validation of the APT cache yourself. In docker, you'd write:

RUN apt update && rosdep install foo

And, ideally:

RUN apt update && rosdep update && rosdep install foo

@codygarver
Copy link
Author

codygarver commented Jan 3, 2023

Since rosdep is acting as a wrapper for apt install foo, I was thinking it made sense to wrap the requirement for that underlying command to succeed (apt update). However, I'm pretty new to using rosdep at all so I'll take your word for it if that doesn't fit the intended use of rosdep.

@peci1
Copy link

peci1 commented Jan 3, 2023

@SubaruArai
Copy link
Contributor

rosdep not only manages apt, but also other package managers, such as rpm, brew, etc.
While I agree adding an option to update the cache (e.g. --update-cache) would be nice, we'll need to add functions for all the package managers (which has OSs that I don't have access to).

tldr: it's quite complicated to implement properly, let alone testing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants