Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update install procedure and prerequisite. #67

Merged
merged 2 commits into from
Mar 17, 2024
Merged

update install procedure and prerequisite. #67

merged 2 commits into from
Mar 17, 2024

Conversation

fujitatomoya
Copy link
Contributor

minor fix to address #66

fujitatomoya
fujitatomoya commented Mar 16, 2024
View reviewed changes
README.md Show resolved Hide resolved
@fujitatomoya
Copy link
Contributor Author

@Yadunund @audrow can you take a look?

Yadunund
Yadunund approved these changes Mar 16, 2024
View reviewed changes
Copy link
Collaborator

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the improving the instructions here.

Yadunund
Yadunund requested changes Mar 16, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@fujitatomoya
add Known Issues section.
5485a29 
Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya
Copy link
Contributor Author

I think Known Issues are expected to be fixed in the future, because those are issues. so technically we do not want to have this section at 1st place, but i believe that at least we can do this for now. (i am not really sure why this problem is happening.)

CC: @Yadunund

Yadunund
Yadunund approved these changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look awesome. Thanks a lot!

@Yadunund Yadunund merged commit e3c3215 into ros-infrastructure:main Mar 17, 2024
2 checks passed
@fujitatomoya fujitatomoya mentioned this pull request Mar 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadunund Yadunund Yadunund approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

@tfoote tfoote Awaiting requested review from tfoote tfoote is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fujitatomoya @Yadunund