Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use venv to run tests in github workflow #95

Closed
wants to merge 1 commit into from

Conversation

rkent
Copy link
Contributor

@rkent rkent commented Apr 10, 2024

Here's my attempt at fixing the pip failure.

@rkent rkent requested review from audrow and tfoote as code owners April 10, 2024 23:33
@tfoote
Copy link
Member

tfoote commented Apr 10, 2024

If we're going to use a venv we should use the one natively from github actions instead of hard coding it ourselves:

I got it working here:
e4ab62a in my tirals in #96

However I was really hoping to keep using the system version as that's what the users will experience unless we change the instructions to explicitly use a venv.

@rkent
Copy link
Contributor Author

rkent commented Apr 11, 2024

OK we're not going to do it this way, so I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants