Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UI for contribute_suggested_repos #396

Open
rkent opened this issue Jun 19, 2024 · 2 comments
Open

Remove UI for contribute_suggested_repos #396

rkent opened this issue Jun 19, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rkent
Copy link

rkent commented Jun 19, 2024

When the contributing PR #194 was first landed, it included a small list of repos that would have an expanded contributing section, with a list of the "help wanted" issues for example. That list was supposed to be manually maintained (see (#194 (comment))

But that list was set initially when the PR was landed, and has never changed:

# Repos to list as suggestiong on the "contribute" page
#
# This must be an array of repository names which acts as a whitelist,
# filtering all known repositories by name.
#
contribute_suggested_repos:
  - moveit
  - catkin_virtualenv
  - tiny_tf

I'd say that the hope to manually maintain this has not panned out. Instead, I propose that we show the expanded contributing page for any repo that has issues with a 'help wanted' or 'good first issue' tag.

@rkent rkent changed the title Show "help wanted" and "good first issue" tabs for all repos with those tags. Remove UI for contribute_suggested_repos Jun 20, 2024
@tfoote tfoote added the enhancement New feature or request label Aug 20, 2024
@tfoote
Copy link
Member

tfoote commented Aug 20, 2024

I agree that maintaining this list manually is not working well. It would be great to use the index information to generate/improve content. One of the challenges is that we currently only fetch and render the github tags in the browser to query the issues, which means that we don't have that information available at generation time. And with the current build time I don't think that we want to add querying github as a dependency for the build either. And we don't want this content going stale in our hosting, nor causing churn in the builds. We also can't do a broad set of github queries/searches due to rate limiting. However if we can get it into a single search that might be possible to leverage and render dynamically.

@tfoote tfoote added the help wanted Extra attention is needed label Aug 20, 2024
@rkent
Copy link
Author

rkent commented Aug 20, 2024

"And we don't want this content going stale in our hosting" is sort of humorous, given that the current content (list of packages wanting help) is almost 5 years old.

My current title of this issue is "Remove UI" but you never really said that you support that. Can I just remove it with your support?

The github rate-limiting issues could probably be solved with some sort of caching, but there are a lot of other issues with rosindex I'd like to work on first, so I doubt if that will get done in the foreseeable future. In any case it is beyond scope for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants