Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rospkg should use sys.platform to identify MacOS #211

Open
rotu opened this issue Sep 9, 2020 · 2 comments · May be fixed by #233
Open

rospkg should use sys.platform to identify MacOS #211

rotu opened this issue Sep 9, 2020 · 2 comments · May be fixed by #233
Labels
enhancement
Milestone
Untargeted

Comments

@rotu
Copy link
Contributor

rotu commented Sep 9, 2020

rospkg uses the sw_vers executable to identify version of macOS. It would be more appropriate to use the platform module https://docs.python.org/3/library/platform.html
@rotu rotu changed the title ros.pkg should use sys.platform to identify MacOS rospkg should use sys.platform to identify MacOS Sep 9, 2020
@dirk-thomas
Copy link
Member

Please consider to contribute a pull request for this idea.

@dirk-thomas dirk-thomas added this to the Untargeted milestone Oct 14, 2020
@rotu
Copy link
Contributor Author

rotu commented Oct 18, 2020

Please consider to contribute a pull request for this idea.

I have no present plans to, which is why I created an issue instead.

@erickisos erickisos linked a pull request Nov 9, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Untargeted
Development

Successfully merging a pull request may close this issue.

Detect macOS/OSX using platform package erickisos/rospkg
2 participants
@rotu @dirk-thomas