replace throw-error with error-log to avoid UAF mentioned in #4175 (#…

…4180) * replace throw-error with error-log to avoid UAF Signed-off-by: GoesM <[email protected]> * fix typo Signed-off-by: GoesM <[email protected]> --------- Signed-off-by: GoesM <[email protected]> Co-authored-by: GoesM <[email protected]>
ros-navigation · Mar 14, 2024 · 9f13cb1 · 9f13cb1
1 parent 09ba08b
commit 9f13cb1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/nav2_util/include/nav2_util/simple_action_server.hpp b/nav2_util/include/nav2_util/simple_action_server.hpp
@@ -315,7 +315,7 @@ class SimpleActionServer
       if (steady_clock::now() - start_time >= server_timeout_) {
         terminate_all();
         if (completion_callback_) {completion_callback_();}
-        throw std::runtime_error("Action callback is still running and missed deadline to stop");
+        error_msg("Action callback is still running and missed deadline to stop");
       }
     }