Set success to false on parameter not found (#4704)

Signed-off-by: Francisco Gonçalves <[email protected]>
ros-navigation · Oct 4, 2024 · e34634c · e34634c
1 parent 1a3b637
commit e34634c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/nav2_mppi_controller/src/parameters_handler.cpp b/nav2_mppi_controller/src/parameters_handler.cpp
@@ -53,6 +53,7 @@ ParametersHandler::dynamicParamsCallback(
 {
   rcl_interfaces::msg::SetParametersResult result;
   std::lock_guard<std::mutex> lock(parameters_change_mutex_);
+  bool success =true;
 
   for (auto & pre_cb : pre_callbacks_) {
     pre_cb();
@@ -67,14 +68,15 @@ ParametersHandler::dynamicParamsCallback(
       callback->second(param);
     } else {
       RCLCPP_WARN(logger_, "Parameter %s not found", param_name.c_str());
+      success = false;
     }
   }
 
   for (auto & post_cb : post_callbacks_) {
     post_cb();
   }
 
-  result.successful = true;
+  result.successful = success;
   return result;
 }